[webkit-changes] [WebKit/WebKit] 44f5b6: AX: Add notification for VoiceOver to announce per...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44f5b661008aadd93b59a8644e97c9cc30b78d16
      https://github.com/WebKit/WebKit/commit/44f5b661008aadd93b59a8644e97c9cc30b78d16
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

  Log Message:
  -----------
  AX: Add notification for VoiceOver to announce percentage of completion of isolated tree creation.
https://bugs.webkit.org/show_bug.cgi?id=270395
rdar://122335605

Reviewed by Tyler Wilcock.

VoiceOver responds to the AXLayoutComplete notification by announcing the page loading progress. This patch combines the percentage of page download with the isolated tree creation progress to report a single measure of page readiness to VoiceOver on the AXLayoutComplete notification.
In addition, we are setting the title of the WebArea element to the same percentage of readiness to allow the VoiceOver user to read it on demand.
Part of this fix involves making AXCoreObject::titleAttributeValue virtual so that the AXIsolatedObject can override this property when it is set by reportLoadingProgress.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::AXLogger::shouldLog):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::titleAttributeValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::createEmpty):
(WebCore::AXIsolatedTree::create):
(WebCore::AXIsolatedTree::loadingProgress):
(WebCore::AXIsolatedTree::reportLoadingProgress):
(WebCore::AXIsolatedTree::resolveAppends):
(WebCore::AXIsolatedTree::reportCreationProgress): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::loadingProgress): Deleted.
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

Canonical link: https://commits.webkit.org/275788@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications