[webkit-changes] [WebKit/WebKit] 669cd0: [Skia] Fix double-free in WebKitTestRunner

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 669cd08179b221aa3a22360738e260d1caef5a4b
      https://github.com/WebKit/WebKit/commit/669cd08179b221aa3a22360738e260d1caef5a4b
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp

  Log Message:
  -----------
  [Skia] Fix double-free in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=270585

Reviewed by Carlos Garcia Campos and Adrian Perez de Castro.

sk_sp::get() returns a raw pointer without increasing
the reference count. To preserve semantics we need
to explicitly increase it when returning the snapshot,
otherwise we risk a double-free.

* Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp:
(WPEToolingBackends::HeadlessViewBackend::snapshot):

Canonical link: https://commits.webkit.org/275784@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications