[webkit-changes] [WebKit/WebKit] db9783: Call ContainerNode::removedFromAncestor at the beg...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db97835b972965876624d9dbe8cb091df15b41d6
      https://github.com/WebKit/WebKit/commit/db97835b972965876624d9dbe8cb091df15b41d6
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/TreeScopeOrderedMap.cpp

  Log Message:
  -----------
  Call ContainerNode::removedFromAncestor at the beginning of Element::removedFromAncestor
https://bugs.webkit.org/show_bug.cgi?id=270032

Reviewed by Chris Dumez.

This PR moves the call to ContainerNode::removedFromAncestor in Element::removedFromAncestor
to the beginning of the function instead of in the middle of a bunch of code in order to
prepare this code for more optimizations in near future.

* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
(WebCore::TreeScopeOrderedMap::get const): Removed the debug assertion that isConnected() is
still true for the element that is being removed since we clear the node flag before calling
updateIdForTreeScope now.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::removedFromAncestor):
(WebCore::Element::updateName):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateId):
(WebCore::Element::updateIdForTreeScope):
(WebCore::Element::updateIdForDocument):

Canonical link: https://commits.webkit.org/275777@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications