[webkit-changes] [WebKit/WebKit] 63a3f0: [JHBuild] Dependencies are not updating after chan...

Vitaly Dyachkov noreply at github.com
Thu Mar 7 00:25:48 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63a3f022275f179c2cacab7c64576f661a439956
      https://github.com/WebKit/WebKit/commit/63a3f022275f179c2cacab7c64576f661a439956
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Tools/Scripts/update-webkit-libs-jhbuild
    M Tools/jhbuild/jhbuild-minimal.modules

  Log Message:
  -----------
  [JHBuild] Dependencies are not updating after changing `Tools/gstreamer/jhbuild.modules`
https://bugs.webkit.org/show_bug.cgi?id=270228

Reviewed by Adrian Perez de Castro.

Starting from 168884 at main, `update-webkit-libs-jhbuild` updates
dependencies only when the configuration has changed.

When `WEBKIT_JHBUILD_MODULESET=minimal-plus-gstreamer` is set,
the script can detect changes in the main modules files:

* `Tools/gtk/jhbuild-minimal-plus-gstreamer.modules` for GTK
* `Tools/wpe/jhbuild-minimal-plus-gstreamer.modules` for WPE

and one level includes:

* `Tools/jhbuild/jhbuild-minimal-plus-gstreamer.modules` for both.

But it doesn't look for further includes.

This patch makes the script check all includes recursively.

Also, we don't need to include `gstreamer/jhbuild.modules` into
`jhbuild-minimal.modules` since we have a dedicated file for this -
`jhbuild-minimal-plus-gstreamer.modules` which includes both.

* Tools/Scripts/update-webkit-libs-jhbuild:
(getJhbuildIncludedFilePaths):
* Tools/jhbuild/jhbuild-minimal.modules:

Canonical link: https://commits.webkit.org/275775@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list