[webkit-changes] [WebKit/WebKit] e644c8: Align criteria for isAlignedForUnder.

[lericaa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e644c808ec390094ac7cc6701b45156ad6ef38e5
      https://github.com/WebKit/WebKit/commit/e644c808ec390094ac7cc6701b45156ad6ef38e5
  Author: Erica Li <lerica at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    A LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash-expected.txt
    A LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash.html
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/style/InlineTextBoxStyle.cpp
    M Source/WebCore/style/InlineTextBoxStyle.h

  Log Message:
  -----------
  Align criteria for isAlignedForUnder.
https://bugs.webkit.org/show_bug.cgi?id=270431

Reviewed by Alan Baradlay.

The criteria of isAlignedForUnder is not aligned between RenderStyle::changeAffectsVisualOverflow from and isAlignedForUnder in InlineTextBoxStyle.

* LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash-expected.txt: Added.
* LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash.html: Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::isAlignedForUnder):
* Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/275771@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications