[webkit-changes] [WebKit/WebKit] 53ebed: [WebGPU] createView on a rgba16float canvas may crash

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53ebed3cf56ae327cbf832e5b1edd3f1ee0949ab
      https://github.com/WebKit/WebKit/commit/53ebed3cf56ae327cbf832e5b1edd3f1ee0949ab
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] createView on a rgba16float canvas may crash
https://bugs.webkit.org/show_bug.cgi?id=270559
<rdar://problem/124117002>

Reviewed by Alex Christensen.

We were setting the pixel format to bgra8unorm but leaving
the WGPU texture format as rgba16float.

That is incorrect.

Additionally add validation around createView in a few additional
places.

* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::textureViewFormatCompatible):
(WebGPU::Device::errorValidatingTextureCreation):
(WebGPU::Texture::createView):
(WebGPU::textureViewFormatCompatible): Deleted.

Canonical link: https://commits.webkit.org/275740@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications