[webkit-changes] [WebKit/WebKit] ad5541: Screen share / getDisplayMedia() buggy behavior an...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad55417ef5c24635d3716669d74cf18dc6bbf60f
      https://github.com/WebKit/WebKit/commit/ad55417ef5c24635d3716669d74cf18dc6bbf60f
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  -----------
  Screen share / getDisplayMedia() buggy behavior and usability issues
https://bugs.webkit.org/show_bug.cgi?id=269961
rdar://123492622

Reviewed by Eric Carlson.

The default width and height if not set are 1920x1080, which might not align with the actual window/screen sizes.
This triggers adding black pixels to preserve the aspect ratio.
If width and height are not provided, we use SCContentFilter contentRect information to fill width and height.

Manually tested for both window and screen capture.
This does not yet the case of window size changing, this will be done as a follow-up.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamConfiguration):

Canonical link: https://commits.webkit.org/275736@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications