[webkit-changes] [WebKit/WebKit] c9cfcc: REGRESSION (275491 at main): [ iOS Debug ] 2x TestWeb...

Jean-Yves Avenard noreply at github.com
Wed Mar 6 01:29:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9cfcceff6a79d150aca63fce8faa01329dc0071
      https://github.com/WebKit/WebKit/commit/c9cfcceff6a79d150aca63fce8faa01329dc0071
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp

  Log Message:
  -----------
  REGRESSION (275491 at main): [ iOS Debug ] 2x TestWebKitAPI.WKWebView.PrintToPDFUsingPrint API tests are constant crashes
https://bugs.webkit.org/show_bug.cgi?id=270523
rdar://124076626

Reviewed by Aditya Keerthi.

In 275494 at main, HashMap::isValidKey was used to check if the map contained the key. This is obviously incorrect.
Use HashMap::contains instead.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::isAsyncReplyHandlerWithDispatcher):
(IPC::Connection::takeAsyncReplyHandlerWithDispatcherWithLockHeld): Similar to taskReplyHandler, check if the key is valid first.

Canonical link: https://commits.webkit.org/275733@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list