[webkit-changes] [WebKit/WebKit] e936ac: NEW TEST [ iOS Debug ] TestWebKitAPI.Fullscreen.Re...

Aditya Keerthi noreply at github.com
Tue Mar 5 20:16:03 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e936ac78d2812779552425a8e777618a407d9364
      https://github.com/WebKit/WebKit/commit/e936ac78d2812779552425a8e777618a407d9364
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-03-05 (Tue, 05 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  -----------
  NEW TEST [ iOS Debug ] TestWebKitAPI.Fullscreen.ResizeEventOrder is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=270527
rdar://124078618

Reviewed by Tim Horton.

Remove incorrect assertions.

In WebKit, `_minimumUnobscuredSizeOverride` and `_maximumUnobscuredSizeOverride`
are only read in fullscreen code, and the values are unused, unless
`_hasOverriddenLayoutParameters` is also true.

Furthermore, SPI clients are free to use these methods as they wish, in which
case the lack of overridden layout parameters is already gracefully handled.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _minimumLayoutSizeOverride]):
(-[WKWebView _minimumUnobscuredSizeOverride]):
(-[WKWebView _maximumUnobscuredSizeOverride]):

Canonical link: https://commits.webkit.org/275724@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list