[webkit-changes] [WebKit/WebKit] c0414c: AX: AccessibilityText is not updated when static t...

Tyler Wilcock noreply at github.com
Tue Mar 5 08:46:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0414c435ce6f20b01a4f4e0e7abc657220615fb
      https://github.com/WebKit/WebKit/commit/c0414c435ce6f20b01a4f4e0e7abc657220615fb
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-05 (Tue, 05 Mar 2024)

  Changed paths:
    A LayoutTests/accessibility/dynamic-text-expected.txt
    A LayoutTests/accessibility/dynamic-text.html
    A LayoutTests/platform/glib/accessibility/dynamic-text-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    A LayoutTests/platform/ios/accessibility/dynamic-text-expected.txt
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: AccessibilityText is not updated when static text descendant changes
https://bugs.webkit.org/show_bug.cgi?id=270356
rdar://123741292

Reviewed by Chris Fleizach.

Add a new TextUnderElementChanged notification to represent this
scenario so we can make precise updates to the isolated tree.

* LayoutTests/accessibility/dynamic-text-expected.txt: Added.
* LayoutTests/accessibility/dynamic-text.html: Added.
* LayoutTests/platform/ios/accessibility/dynamic-text-expected.txt: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new test.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleTextChanged):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::dependsOnTextUnderElement const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
(WebCore::AXIsolatedTree::updateDependentProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::updateNodeProperty):

Canonical link: https://commits.webkit.org/275693@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list