[webkit-changes] [WebKit/WebKit] b39a83: [Cocoa] Tell AVFoundation to not log urls in priva...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b39a8381cc14da138f10ddd6f4d32ed855c0ac1c
      https://github.com/WebKit/WebKit/commit/b39a8381cc14da138f10ddd6f4d32ed855c0ac1c
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2024-03-05 (Tue, 05 Mar 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/platform/graphics/MediaPlayer.cpp
    M Source/WebCore/platform/graphics/MediaPlayer.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  [Cocoa] Tell AVFoundation to not log urls in private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=270476
rdar://118855410

Reviewed by Jer Noble.

Add a key to the options dictionary passed to the AVURLAsset constructor when WebKit
is in private browsing mode so it knows to never log urls.

* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: Define new constant string.
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm:

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Make the code the same on iOS
as on every other platform.

* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine): Update name of instance variable.
(WebCore::MediaPlayer::setPrivateBrowsingMode): Ditto.
* Source/WebCore/platform/graphics/MediaPlayer.h:

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Add new key to options
dictionary when in private browsing mode.

Canonical link: https://commits.webkit.org/275691@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications