[webkit-changes] [WebKit/WebKit] 6c90d8: REGRESSION(273918 at main): WebAuthn cancel completio...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c90d822b9c4878a3e214be8539bfaa2a066f389
      https://github.com/WebKit/WebKit/commit/6c90d822b9c4878a3e214be8539bfaa2a066f389
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  -----------
  REGRESSION(273918 at main): WebAuthn cancel completion handler is never called
https://bugs.webkit.org/show_bug.cgi?id=270473
rdar://122985287

Reviewed by Pascoe.

A completion handler from the web process is stored in `m_cancelHandler` to be called by the delegate.
However, the delegate is immediately cleared, so the completion handler will never be called. We
shouldn’t clear the delegate and controller until `m_cancelHandler` is called.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Canonical link: https://commits.webkit.org/275673@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications