[webkit-changes] [WebKit/WebKit] 04d497: WebAuthn userHandle must be null, not empty string

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04d4979c9e1d766b1ad11eac36f7593ee8bb268d
      https://github.com/WebKit/WebKit/commit/04d4979c9e1d766b1ad11eac36f7593ee8bb268d
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  -----------
  WebAuthn userHandle must be null, not empty string
rdar://92305724
https://bugs.webkit.org/show_bug.cgi?id=239737

Reviewed by Brent Fulgham.

Whenever we started calling out to AuthenticationServicesAgent, we started passing no user handle
as an empty ArrayBuffer instead of null. This isn't allowed by the spec, if there's no user handle
we should return null. This change does that by treating an empty user handle as null.

This is already checked for in LayoutTests, however, they don't exercise the
serialization back and forth from the daemon.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::toArrayBuffer):

Canonical link: https://commits.webkit.org/275669@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications