[webkit-changes] [WebKit/WebKit] 0ade44: Check Texture::supportsBlending in addition to has...

Alex Christensen noreply at github.com
Mon Mar 4 16:49:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ade4480b548839fd84b43494f5d1eef8ce47792
      https://github.com/WebKit/WebKit/commit/0ade4480b548839fd84b43494f5d1eef8ce47792
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/texture-supports-blending-expected.txt
    A LayoutTests/fast/webgpu/texture-supports-blending.html
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  Check Texture::supportsBlending in addition to hasAlphaChannel
https://bugs.webkit.org/show_bug.cgi?id=270484
rdar://123811134

Reviewed by Mike Wyrzykowski.

This is being discussed in https://github.com/gpuweb/gpuweb/issues/4506
We don't want to crash when using Metal.

* LayoutTests/fast/webgpu/texture-supports-blending-expected.txt: Added.
* LayoutTests/fast/webgpu/texture-supports-blending.html: Added.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::hasAlphaChannel): Deleted.

Canonical link: https://commits.webkit.org/275662@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list