[webkit-changes] [WebKit/WebKit] 68c3a9: Pass the full host name to CoreTelephony when chec...

Wenson Hsieh noreply at github.com
Mon Mar 4 15:05:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68c3a98c6b908b1f8f9062818373420a32697f44
      https://github.com/WebKit/WebKit/commit/68c3a98c6b908b1f8f9062818373420a32697f44
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/PAL/pal/spi/cocoa/CoreTelephonySPI.h
    M Source/WebKit/UIProcess/Cocoa/CoreTelephonyUtilities.mm
    M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm

  Log Message:
  -----------
  Pass the full host name to CoreTelephony when checking whether eSIM AutoFill should be allowed
https://bugs.webkit.org/show_bug.cgi?id=270471
rdar://123280143

Reviewed by Megan Gardner and Abrar Rahman Protyasha.

As it turns out, `-isAutofilleSIMIdAllowedForDomain:error:` expects the full host, rather than just
the top domain; address this, and also clean up the feature flag and remove some staging that's now
unnecessary while we're here.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cocoa/CoreTelephonySPI.h:
* Source/WebKit/UIProcess/Cocoa/CoreTelephonyUtilities.mm:
(WebKit::shouldAllowAutoFillForCellularIdentifiers):
* Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(TestWebKitAPI::allowESIMAutoFillForWebKit):
(TestWebKitAPI::TEST):
(TestWebKitAPI::allowESIMAutoFillForWebKitDomains): Deleted.

Canonical link: https://commits.webkit.org/275656@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list