[webkit-changes] [WebKit/WebKit] bcca5f: Implement field-sizing support for input and textarea
Luke Warlow
noreply at github.com
Mon Mar 4 13:21:26 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bcca5fc0fa1715d7da3e05cac22fb460a12539f0
https://github.com/WebKit/WebKit/commit/bcca5fc0fa1715d7da3e05cac22fb460a12539f0
Author: Luke Warlow <lwarlow at igalia.com>
Date: 2024-03-04 (Mon, 04 Mar 2024)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html
A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt
A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt
A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt
R LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt
R LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt
A LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt
A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt
A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt
A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt
M Source/WebCore/rendering/RenderTextControl.cpp
Log Message:
-----------
Implement field-sizing support for input and textarea
https://bugs.webkit.org/show_bug.cgi?id=269125
Reviewed by Aditya Keerthi.
Inputs and textareas with field-sizing: content now size based on their content size not intrinsic.
This patch does not include the handling for caret width, autofill, or placeholders.
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added.
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added.
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt: Removed.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added.
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt: Removed.
* LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added.
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight const):
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths const):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
Canonical link: https://commits.webkit.org/275649@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list