[webkit-changes] [WebKit/WebKit] b3a8dd: Build fix: WK_LIBFUZZER_COVERAGE should default to...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3a8dd34740ae0278032de7fe17a10bfc9d8b3a7
      https://github.com/WebKit/WebKit/commit/b3a8dd34740ae0278032de7fe17a10bfc9d8b3a7
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M Configurations/Sanitizers.xcconfig

  Log Message:
  -----------
  Build fix: WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled
https://bugs.webkit.org/show_bug.cgi?id=269796
<rdar://123317614>

Unreviewed build fix.

Enabling Fuzzilli failed to compile and link with
-fsanitize-coverage=trace-pc-guard.

The fix is to have separate OTHER_CFLAGS and OTHER_LDFLAGS for Fuzzilli
and LibFuzzer that both use the shared $(WK_SANITIZER_COVERAGE).

* Configurations/Sanitizers.xcconfig:
(WK_SANITIZER_OTHER_CFLAGS):
- Rearrange switches.
(WK_SANITIZER_OTHER_CPLUSPLUSFLAGS):
- Remove $(WK_LIBFUZZER_OTHER_CPLUSPLUSFLAGS_$(ENABLE_LIBFUZZER)) as it
  is not used.
(WK_SANITIZER_OTHER_LDFLAGS):
- Add $(WK_FUZZILLI_OTHER_LDFLAGS_$(ENABLE_FUZZILLI)).
(WK_SANITIZER_COVERAGE*):
- Rename from WK_LIBFUZZER_COVERAGE.
(WK_SANITIZER_COVERAGE_OTHER_FLAGS): Add.
- This is shared between Fuzzilli and LibFuzzer.
(WK_LIBFUZZER_OTHER_CFLAGS_YES):
(WK_LIBFUZZER_OTHER_LDFLAGS_YES):
(WK_FUZZILLI_OTHER_CFLAGS_YES): Add.
(WK_FUZZILLI_OTHER_LDFLAGS_YES): Add.
- Make use of $(WK_SANITIZER_COVERAGE_OTHER_FLAGS).

Canonical link: https://commits.webkit.org/275632@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications