[webkit-changes] [WebKit/WebKit] 11d5d6: Viewport unit conversion should work in empty frame

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11d5d62ba36c7db1aab5cdf2b465dc8a8890eaf9
      https://github.com/WebKit/WebKit/commit/11d5d62ba36c7db1aab5cdf2b465dc8a8890eaf9
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    A LayoutTests/fast/css/viewport-unit-conversion-crash-expected.txt
    A LayoutTests/fast/css/viewport-unit-conversion-crash.html
    M Source/WebCore/css/CSSPrimitiveValue.cpp

  Log Message:
  -----------
  Viewport unit conversion should work in empty frame
https://bugs.webkit.org/show_bug.cgi?id=270289
rdar://116715588

Reviewed by Alan Baradlay.

We hit a release assert in some cases.

* LayoutTests/fast/css/viewport-unit-conversion-crash-expected.txt: Added.
* LayoutTests/fast/css/viewport-unit-conversion-crash.html: Added.
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::convertingToLengthHasRequiredConversionData const):

An empty viewport is a valid reference for resolving viewport units. The only requirement here is that we have access to one.
Also test for non-fixed conversion first to make the code less confusing.

Canonical link: https://commits.webkit.org/275620@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications