[webkit-changes] [WebKit/WebKit] 81bff4: REGRESSION(274689 at main): [GTK][Debug] Triggers ass...

Philippe Normand noreply at github.com
Mon Mar 4 01:25:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81bff4c4360f4a33ae558e9d02878947af20c011
      https://github.com/WebKit/WebKit/commit/81bff4c4360f4a33ae558e9d02878947af20c011
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-03-04 (Mon, 04 Mar 2024)

  Changed paths:
    M Source/WebCore/loader/cache/CachedFont.cpp

  Log Message:
  -----------
  REGRESSION(274689 at main): [GTK][Debug] Triggers assert on WOFF2 tests
https://bugs.webkit.org/show_bug.cgi?id=270414

Reviewed by Michael Catanzaro.

The convertWOFFToSfntIfNecessary() function can set the buffer to nullptr, specially if the
woff2::ConvertWOFF2ToTTF() call in convertWOFFToSfnt() fails. This patch re-introduces the buffer
check that was removed in 274689 at main.

* Source/WebCore/loader/cache/CachedFont.cpp:
(WebCore::CachedFont::createCustomFontData):

Canonical link: https://commits.webkit.org/275617@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list