[webkit-changes] [WebKit/WebKit] 8ebb25: [IFC][Subpixel] do no round-to-integral RenderStyl...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ebb25c74250c69344a24f7f29cc00636a71a733
      https://github.com/WebKit/WebKit/commit/8ebb25c74250c69344a24f7f29cc00636a71a733
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-03-03 (Sun, 03 Mar 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-placeholder-lineheight-expected.txt
    M LayoutTests/platform/ios-wk2/fast/forms/textAreaLineHeight-expected.txt
    M LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac-monterey/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac-ventura/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/rendering/LegacyRootInlineBox.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderLayoutState.cpp
    M Source/WebCore/rendering/RenderLineBreak.cpp
    M Source/WebCore/rendering/RenderLineBreak.h
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h

  Log Message:
  -----------
  [IFC][Subpixel] do no round-to-integral RenderStyle::computedLineHeight
https://bugs.webkit.org/show_bug.cgi?id=270411

Reviewed by Antti Koivisto.

This is in preparation for removing integral (vertical) snapping.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/textarea-placeholder-lineheight-expected.txt:
* LayoutTests/platform/ios-wk2/fast/forms/textAreaLineHeight-expected.txt:
* LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac-monterey/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac-ventura/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::lineGrid):
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight const):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::lineHeight const):
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::RenderLayoutState::computeLineGridPaginationOrigin):
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::RenderLineBreak):
(WebCore::RenderLineBreak::lineHeight const):
(WebCore::RenderLineBreak::updateFromStyle):
(WebCore::m_cachedLineHeight): Deleted.
* Source/WebCore/rendering/RenderLineBreak.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computedLineHeight const):
(WebCore::RenderStyle::computeLineHeight const):
* Source/WebCore/rendering/style/RenderStyle.h:

Canonical link: https://commits.webkit.org/275601@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications