[webkit-changes] [WebKit/WebKit] da4ede: VideoSourceIdentifier should contain std::optional...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da4ede4b4b39958909e39b0e8bc6b34be16a7178
      https://github.com/WebKit/WebKit/commit/da4ede4b4b39958909e39b0e8bc6b34be16a7178
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-03-02 (Sat, 02 Mar 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/optional-media-identifier-expected.txt
    A LayoutTests/fast/webgpu/optional-media-identifier.html
    M Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h
    M Source/WebCore/platform/VideoPixelFormat.cpp
    M Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp

  Log Message:
  -----------
  VideoSourceIdentifier should contain std::optional<WebCore::MediaPlayerIdentifier>
https://bugs.webkit.org/show_bug.cgi?id=270397
rdar://123810898

Reviewed by Mike Wyrzykowski.

Otherwise in RemoteDeviceProxy::importExternalTexture we send a non-nullopt identifier with a value of 0
when what we wanted was to send nullopt.  Identifiers with a value of 0 fail to decode on the receiving
side.  Also fix a few small issues: removed an invalid debug assertion, and call some completion handlers
in error cases.

* LayoutTests/fast/webgpu/optional-media-identifier-expected.txt: Added.
* LayoutTests/fast/webgpu/optional-media-identifier.html: Added.
* Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h:
(WebCore::GPUExternalTextureDescriptor::mediaIdentifierForSource):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h:
* Source/WebCore/platform/VideoPixelFormat.cpp:
(WebCore::convertVideoFramePixelFormat):
* Source/WebKit/Shared/WebGPU/WebGPUExternalTextureDescriptor.cpp:
(WebKit::WebGPU::ConvertToBackingContext::convertToBacking):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp:
(WebKit::WebGPU::RemoteAdapterProxy::requestDevice):

Canonical link: https://commits.webkit.org/275594@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications