[webkit-changes] [WebKit/WebKit] 263042: Implement ariaBrailleLabel and ariaBrailleRoleDesc...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 263042a5d0c6b67380c99c44f2da65f35fdfb886
      https://github.com/WebKit/WebKit/commit/263042a5d0c6b67380c99c44f2da65f35fdfb886
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-03-01 (Fri, 01 Mar 2024)

  Changed paths:
    M LayoutTests/accessibility/ARIA-reflection-expected.txt
    M LayoutTests/accessibility/ARIA-reflection.html
    A LayoutTests/accessibility/aria-braillelabel-expected.txt
    A LayoutTests/accessibility/aria-braillelabel.html
    A LayoutTests/accessibility/aria-brailleroledescription-expected.txt
    A LayoutTests/accessibility/aria-brailleroledescription.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AriaAttributes.idl
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/dom/ElementInternals.idl
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  Implement ariaBrailleLabel and ariaBrailleRoleDescription element reflection properties
https://bugs.webkit.org/show_bug.cgi?id=270387
rdar://problem/123926949

Reviewed by Chris Fleizach.

This patch also removes the DefaultARIAForCustomElementsEnabled feature
entirely, as it has been enabled by default for a year, and fixes a bug
where AXPropertyName::{BrailleLabel, BrailleRoleDescription} were not
updated after dynamic changes.

* LayoutTests/accessibility/aria-braillelabel-expected.txt: Added.
* LayoutTests/accessibility/aria-braillelabel.html: Added.
* LayoutTests/accessibility/aria-brailleroledescription-expected.txt: Added.
* LayoutTests/accessibility/aria-brailleroledescription.html: Added.
* LayoutTests/accessibility/ARIA-reflection-expected.txt:
* LayoutTests/accessibility/ARIA-reflection.html:

* LayoutTests/platform/ios/TestExpectations:
Enable new tests.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
Skip new tests.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
Remove DefaultARIAForCustomElementsEnabled.
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AriaAttributes.idl:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/dom/ElementInternals.idl:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::brailleLabel const):
(WTR::AccessibilityUIElement::brailleRoleDescription const):

Canonical link: https://commits.webkit.org/275591@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications