[webkit-changes] [WebKit/WebKit] 6a7b2d: [GTK] Crash in WebPageProxy::getLoadDecisionForIcon

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a7b2d62c79487e7c4040fadf997e9238e6d9047
      https://github.com/WebKit/WebKit/commit/6a7b2d62c79487e7c4040fadf997e9238e6d9047
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-03-01 (Fri, 01 Mar 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [GTK] Crash in WebPageProxy::getLoadDecisionForIcon
https://bugs.webkit.org/show_bug.cgi?id=269699

Reviewed by Michael Catanzaro.

This probably regressed in 274563 at main, that changed the way a
SharedBuffer is serialized for IPC and now segments are sent, instead of
the contiguous. So, in getLoadDecisionForIcon() we need to handle the
case of data being non contiguous, by using SharedBufferReference::unsafeBuffer()

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getLoadDecisionForIcon):

Canonical link: https://commits.webkit.org/275540@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications