[webkit-changes] [WebKit/WebKit] 63d824: [Writing Tools] Writing Tools context menu item ma...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63d8246828b2162cb11803da40cb479eca9922b1
      https://github.com/WebKit/WebKit/commit/63d8246828b2162cb11803da40cb479eca9922b1
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-06-30 (Sun, 30 Jun 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.h
    M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] Writing Tools context menu item may still show up even when using UIWritingToolsBehaviorNone
https://bugs.webkit.org/show_bug.cgi?id=276040
rdar://130825002

Reviewed by Wenson Hsieh.

Implement the `writingToolsBehavior` property of the `{UI|NS}TextInputTraits` protocol on WKContentViewInteraction and WKWebView,
rather than set it on the `writingToolsBehavior` property on the UITextInputTraits object itself on iOS.

This also has the advantage of unifying the behavior across the platforms.

* Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView writingToolsBehavior]):
(-[WKWebView wantsWritingToolsInlineEditing]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _web_wantsWritingToolsInlineEditing]): Deleted.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _updateTextInputTraits:]):
(-[WKContentView writingToolsBehavior]):
(-[WKContentView _startWritingToolsForWebView:]): Deleted.
(-[WKContentView wantsWritingToolsInlineEditing]): Deleted.
* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.h:
* Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.mm:
(-[WKExtendedTextInputTraits restoreDefaultValues]):
(-[WKExtendedTextInputTraits restoreDefaultWritingToolsBehaviorValue]): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(-[WritingToolsWKWebView writingToolsBehaviorForTesting]):
(TEST(WritingTools, WantsInlineEditing)):
(TEST(WritingTools, WritingToolsBehaviorNonEditableWithSelection)):
(TEST(WritingTools, WritingToolsBehaviorWithNoSelection)):
(TEST(WritingTools, WritingToolsBehaviorEditableWithSelection)):
(TEST(WritingTools, APIWithBehaviorNone)):
(TEST(WritingTools, APIWithBehaviorDefault)):
(TEST(WritingTools, APIWithBehaviorComplete)):
(TEST(WritingTools, ShowAffordance)):
(TEST(WritingTools, ShowAffordanceForMultipleLines)):

Canonical link: https://commits.webkit.org/280518@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications