[webkit-changes] [WebKit/WebKit] 340844: Drop AudioArray::data() in favor of span()

Sun Jun 30 15:16:11 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34084452dcecee993a49c0708573ca71d025fc59
      https://github.com/WebKit/WebKit/commit/34084452dcecee993a49c0708573ca71d025fc59
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-06-30 (Sun, 30 Jun 2024)

  Changed paths:
    M Source/WebCore/Modules/webaudio/AudioBuffer.cpp
    M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
    M Source/WebCore/Modules/webaudio/AudioListener.cpp
    M Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp
    M Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp
    M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp
    M Source/WebCore/Modules/webaudio/BiquadProcessor.cpp
    M Source/WebCore/Modules/webaudio/ConstantSourceNode.cpp
    M Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp
    M Source/WebCore/Modules/webaudio/GainNode.cpp
    M Source/WebCore/Modules/webaudio/IIRProcessor.cpp
    M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceCocoa.cpp
    M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp
    M Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp
    M Source/WebCore/Modules/webaudio/OscillatorNode.cpp
    M Source/WebCore/Modules/webaudio/PeriodicWave.cpp
    M Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp
    M Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp
    M Source/WebCore/Modules/webaudio/StereoPannerNode.cpp
    M Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp
    M Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp
    M Source/WebCore/platform/audio/AudioArray.h
    M Source/WebCore/platform/audio/AudioBus.cpp
    M Source/WebCore/platform/audio/AudioChannel.cpp
    M Source/WebCore/platform/audio/AudioChannel.h
    M Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp
    M Source/WebCore/platform/audio/AudioResampler.cpp
    M Source/WebCore/platform/audio/AudioResamplerKernel.cpp
    M Source/WebCore/platform/audio/Biquad.cpp
    M Source/WebCore/platform/audio/DirectConvolver.cpp
    M Source/WebCore/platform/audio/DownSampler.cpp
    M Source/WebCore/platform/audio/DynamicsCompressor.cpp
    M Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp
    M Source/WebCore/platform/audio/EqualPowerPanner.cpp
    M Source/WebCore/platform/audio/FFTConvolver.cpp
    M Source/WebCore/platform/audio/FFTFrame.cpp
    M Source/WebCore/platform/audio/HRTFKernel.cpp
    M Source/WebCore/platform/audio/HRTFPanner.cpp
    M Source/WebCore/platform/audio/IIRFilter.cpp
    M Source/WebCore/platform/audio/MultiChannelResampler.cpp
    M Source/WebCore/platform/audio/PushPullFIFO.cpp
    M Source/WebCore/platform/audio/Reverb.cpp
    M Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp
    M Source/WebCore/platform/audio/ReverbConvolver.cpp
    M Source/WebCore/platform/audio/ReverbConvolverStage.cpp
    M Source/WebCore/platform/audio/ReverbInputBuffer.cpp
    M Source/WebCore/platform/audio/SincResampler.cpp
    M Source/WebCore/platform/audio/StereoPanner.cpp
    M Source/WebCore/platform/audio/UpSampler.cpp
    M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
    M Source/WebCore/platform/audio/mac/FFTFrameMac.cpp
    M Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
    M Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.mm

  Log Message:
  -----------
  Drop AudioArray::data() in favor of span()
https://bugs.webkit.org/show_bug.cgi?id=276036

Reviewed by Darin Adler.

* Source/WebCore/Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::AudioBuffer):
* Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
* Source/WebCore/Modules/webaudio/AudioListener.cpp:
(WebCore::AudioListener::updateValuesIfNeeded):
(WebCore::AudioListener::positionXValues):
(WebCore::AudioListener::positionYValues):
(WebCore::AudioListener::positionZValues):
(WebCore::AudioListener::forwardXValues):
(WebCore::AudioListener::forwardYValues):
(WebCore::AudioListener::forwardZValues):
(WebCore::AudioListener::upXValues):
(WebCore::AudioListener::upYValues):
(WebCore::AudioListener::upZValues):
* Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
* Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp:
(WebCore::AudioWorkletNode::process):
* Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::constructFrozenKeyValueObject):
(WebCore::constructFrozenJSArray):
(WebCore::copyDataFromJSArrayToBuses):
(WebCore::copyDataFromBusesToJSArray):
(WebCore::copyDataFromParameterMapToJSObject):
* Source/WebCore/Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::process):
* Source/WebCore/Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::process):
* Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::processARate):
(WebCore::DelayDSPKernel::processKRate):
* Source/WebCore/Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::process):
* Source/WebCore/Modules/webaudio/IIRProcessor.cpp:
(WebCore::IIRProcessor::process):
* Source/WebCore/Modules/webaudio/MediaStreamAudioSourceCocoa.cpp:
(WebCore::copyChannelData):
* Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::renderOnAudioThread):
* Source/WebCore/Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::OscillatorNode::process):
* Source/WebCore/Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
* Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::writeInput):
(WebCore::RealtimeAnalyser::doFFTAnalysisIfNecessary):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getFloatTimeDomainData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):
* Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::process):
* Source/WebCore/Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::process):
* Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
* Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::process):
* Source/WebCore/platform/audio/AudioArray.h:
(WebCore::AudioArray::mutableSpan):
(WebCore::AudioArray::span const):
(WebCore::AudioArray::at):
(WebCore::AudioArray::at const):
(WebCore::AudioArray::zero):
(WebCore::AudioArray::zeroRange):
(WebCore::AudioArray::copyToRange):
(WebCore::AudioArray::containsConstantValue const):
(WebCore::AudioArray::span): Deleted.
(WebCore::AudioArray::data): Deleted.
(WebCore::AudioArray::data const): Deleted.
* Source/WebCore/platform/audio/AudioBus.cpp:
(WebCore::AudioBus::speakersSumFromByDownMixing):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
(WebCore::AudioBus::createByMixingToMono):
* Source/WebCore/platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale):
(WebCore::AudioChannel::copyFrom):
(WebCore::AudioChannel::copyFromRange):
(WebCore::AudioChannel::sumFrom):
(WebCore::AudioChannel::maxAbsValue const):
* Source/WebCore/platform/audio/AudioChannel.h:
* Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::process):
* Source/WebCore/platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::process):
* Source/WebCore/platform/audio/AudioResamplerKernel.cpp:
(WebCore::AudioResamplerKernel::getSourcePointer):
(WebCore::AudioResamplerKernel::process):
* Source/WebCore/platform/audio/Biquad.cpp:
(WebCore::Biquad::process):
(WebCore::Biquad::processFast):
(WebCore::Biquad::reset):
* Source/WebCore/platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):
* Source/WebCore/platform/audio/DownSampler.cpp:
(WebCore::DownSampler::process):
* Source/WebCore/platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::process):
* Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
* Source/WebCore/platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
(WebCore::EqualPowerPanner::panWithSampleAccurateValues):
* Source/WebCore/platform/audio/FFTConvolver.cpp:
(WebCore::FFTConvolver::process):
* Source/WebCore/platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::doPaddedFFT):
(WebCore::FFTFrame::createInterpolatedFrame):
(WebCore::FFTFrame::scaleFFT):
(WebCore::FFTFrame::multiply):
* Source/WebCore/platform/audio/HRTFKernel.cpp:
(WebCore::extractAverageGroupDelay):
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createImpulseResponse):
* Source/WebCore/platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::pan):
* Source/WebCore/platform/audio/IIRFilter.cpp:
(WebCore::IIRFilter::tailTime):
* Source/WebCore/platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
* Source/WebCore/platform/audio/PushPullFIFO.cpp:
(WebCore::PushPullFIFO::push):
(WebCore::PushPullFIFO::pull):
* Source/WebCore/platform/audio/Reverb.cpp:
(WebCore::calculateNormalizationScale):
* Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp:
(WebCore::ReverbAccumulationBuffer::readAndClear):
(WebCore::ReverbAccumulationBuffer::accumulate):
* Source/WebCore/platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::process):
* Source/WebCore/platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
* Source/WebCore/platform/audio/ReverbInputBuffer.cpp:
(WebCore::ReverbInputBuffer::write):
(WebCore::ReverbInputBuffer::directReadFrom):
* Source/WebCore/platform/audio/SincResampler.cpp:
(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::updateRegions):
* Source/WebCore/platform/audio/StereoPanner.cpp:
(WebCore::StereoPanner::panWithSampleAccurateValues):
(WebCore::StereoPanner::panToTargetValue):
* Source/WebCore/platform/audio/UpSampler.cpp:
(WebCore::UpSampler::process):
* Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp:
(WebCore::AudioFileReader::createBus):
* Source/WebCore/platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::doFFT):
* Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::provideInput):
* Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.mm:
(WebCore::WebAudioSourceProviderCocoa::provideInput):

Canonical link: https://commits.webkit.org/280514@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications