[webkit-changes] [WebKit/WebKit] 5ff93f: Removed text content does not always get repainted...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ff93f10e6be9083d4d0826ce8e61a938a635125
      https://github.com/WebKit/WebKit/commit/5ff93f10e6be9083d4d0826ce8e61a938a635125
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
    A LayoutTests/fast/text/display-contents-with-text-remove-crash-expected.txt
    A LayoutTests/fast/text/display-contents-with-text-remove-crash.html
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Removed text content does not always get repainted when it is inside 'display: contents'
https://bugs.webkit.org/show_bug.cgi?id=276034
<rdar://130755978>

Reviewed by Antti Koivisto.

We miss marking the containing block dirty when removing a text renderer where
the destroy root happens to be 'display: contents' with no renderer.

* LayoutTests/fast/text/display-contents-with-text-remove-crash-expected.txt: Added.
* LayoutTests/fast/text/display-contents-with-text-remove-crash.html: Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::repaintAndMarkContainingBlockDirtyBeforeTearDown):
(WebCore::RenderTreeUpdater::tearDownRenderers):

Canonical link: https://commits.webkit.org/280504@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications