[webkit-changes] [WebKit/WebKit] a760ea: [css-writing-modes] Refactor TextFlow to be a stru...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a760ea6009c1bed9b6bba2e890f6fa1a1fcf3d60
      https://github.com/WebKit/WebKit/commit/a760ea6009c1bed9b6bba2e890f6fa1a1fcf3d60
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyle.h
    M Source/WebCore/platform/text/WritingMode.h
    M Source/WebCore/rendering/RenderCounter.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/WritingModeTests.cpp

  Log Message:
  -----------
  [css-writing-modes] Refactor TextFlow to be a struct instead of an enum
https://bugs.webkit.org/show_bug.cgi?id=275966
rdar://130787071

Reviewed by Alan Baradlay.

Names like InlineEastBlockSouth / InlineWestBlockSouth / etc. are quite confusing.
Refactor TextFlow to be a struct instead.

* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::counterForSystemDisclosureClosed):
(WebCore::CSSCounterStyle::counterForSystemDisclosureOpen):
* Source/WebCore/css/CSSCounterStyle.h:
* Source/WebCore/platform/text/WritingMode.h:
(WebCore::TextFlow::isReversed):
(WebCore::TextFlow::isFlipped):
(WebCore::TextFlow::isVertical):
(WebCore::TextFlow::isFlippedLines):
(WebCore::makeTextFlow):
(WebCore::isVerticalWritingMode):
(WebCore::isFlippedWritingMode):
(WebCore::isFlippedLinesWritingMode):
(WebCore::mapLogicalSideToPhysicalSide):
(WebCore::mapPhysicalSideToLogicalSide):
(WebCore::mapLogicalCornerToPhysicalCorner):
(WebCore::mapPhysicalCornerToLogicalCorner):
(WebCore::mapLogicalAxisToPhysicalAxis):
(WebCore::mapPhysicalAxisToLogicalAxis):
(WebCore::operator<<):
(WebCore::makeTextFlowInitalizer): Deleted.
(): Deleted.
(WebCore::isReversedTextFlow): Deleted.
(WebCore::isFlippedTextFlow): Deleted.
(WebCore::isVerticalTextFlow): Deleted.
(WebCore::isFlippedLinesTextFlow): Deleted.
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::originalText const):
* Tools/TestWebKitAPI/Tests/WebCore/WritingModeTests.cpp:

Canonical link: https://commits.webkit.org/280494@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications