[webkit-changes] [WebKit/WebKit] bd4053: UIIntelligenceSupport context retrieval should avo...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd405371c620acba4b52f4cae521c98c02592156
      https://github.com/WebKit/WebKit/commit/bd405371c620acba4b52f4cae521c98c02592156
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    A LayoutTests/fast/text-extraction/avoid-extracting-password-fields-expected.txt
    A LayoutTests/fast/text-extraction/avoid-extracting-password-fields.html
    M Source/WebCore/page/text-extraction/TextExtraction.cpp

  Log Message:
  -----------
  UIIntelligenceSupport context retrieval should avoid extracting text in password fields
https://bugs.webkit.org/show_bug.cgi?id=276022
rdar://129415710

Reviewed by Richard Robinson.

Make a couple of minor adjustments to context retrieval:

1.  Consider text fields as secure for the purposes of context retrieval, if they were previously
    password fields.

2.  Skip extracting text inside password fields altogether (note that we still extract some metadata
    about the password field itself, such as the placeholder text).

* LayoutTests/fast/text-extraction/avoid-extracting-password-fields-expected.txt: Added.
* LayoutTests/fast/text-extraction/avoid-extracting-password-fields.html: Added.

Add a layout test to exercise the change.

* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::shouldTreatAsPasswordField):
(WebCore::TextExtraction::extractItemData):

See comments above.

Canonical link: https://commits.webkit.org/280487@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications