[webkit-changes] [WebKit/WebKit] 267c22: Use a const & when when getting tracks in minSizeF...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 267c225fb2d3c6ba94a3426f442a6dda40eecb2d
      https://github.com/WebKit/WebKit/commit/267c225fb2d3c6ba94a3426f442a6dda40eecb2d
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    A PerformanceTests/Layout/auto-masonry-1000-columns-10000-items.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  Use a const & when when getting tracks in minSizeForChild
https://bugs.webkit.org/show_bug.cgi?id=275972
rdar://problem/130728344

Reviewed by Sammy Gill.

We are doing unnecessary copies of GridTracks when grabbing the allTracks.

Based on the microbenchmark I wrote it reduced masonry layout from ~1 minute to ~1 second.
Grid layout decreased from ~100 ms to ~30 ms.
Tested on M1 Ultra.

* PerformanceTests/Layout/auto-masonry-1000-columns-10000-items.html: Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):

Canonical link: https://commits.webkit.org/280473@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications