[webkit-changes] [WebKit/WebKit] b7f69a: REGRESSION (279833 at main): webrtc/vp8-then-h264-gpu...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7f69a1c3709ddda04cd84b14dfb1068a93b6865
      https://github.com/WebKit/WebKit/commit/b7f69a1c3709ddda04cd84b14dfb1068a93b6865
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
    M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
    A Source/WebKit/WebProcess/GPU/GPUProcessConnectionIdentifier.h
    M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  -----------
  REGRESSION (279833 at main): webrtc/vp8-then-h264-gpu-process-crash.html is consistently crashing
https://bugs.webkit.org/show_bug.cgi?id=275741
rdar://130288947

Reviewed by Matt Woodrow.

The test would terminate GPU process.
Due WebRTC doing capture, it UI would restart the GPU process.
If WCP was in process of doing IPC sends, the termination would would
cause unresponsiveness event in WCP.
The unresponsiveness termination would intend to terminate the previous
process, but would actually terminate the new process.

Fix by associating the unresponsiveness call with
GPUProcessConnectionIdentifier.

* Source/WebKit/Scripts/webkit/messages.py:
(serialized_identifiers):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createGPUProcessConnection):
(WebKit::WebProcessProxy::gpuProcessConnectionDidBecomeUnresponsive):
(WebKit::WebProcessProxy::gpuProcessExited):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.h:
(WebKit::GPUProcessConnection::identifier const):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureGPUProcessConnection):
(WebKit::WebProcess::gpuProcessConnectionDidBecomeUnresponsive):

Canonical link: https://commits.webkit.org/280452@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications