[webkit-changes] [WebKit/WebKit] df95b2: Consider writing-mode when handling disclosure cou...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df95b23150a90ce8bccb3bc66e0348a24ac09331
      https://github.com/WebKit/WebKit/commit/df95b23150a90ce8bccb3bc66e0348a24ac09331
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WTF/wtf/unicode/CharacterNames.h
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyle.h
    M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
    M Source/WebCore/css/CSSCounterStyleDescriptors.h
    M Source/WebCore/css/CSSCounterStyleRule.cpp
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/counterStyles.css
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/RenderCounter.cpp
    M Source/WebCore/rendering/RenderListMarker.cpp

  Log Message:
  -----------
  Consider writing-mode when handling disclosure counter-styles
https://bugs.webkit.org/show_bug.cgi?id=275835
rdar://130468537

Reviewed by Tim Nguyen.

- We now consider writing-mode when handling disclosure-closed
and disclosure-open counter-styles.
- We handle disclosure-open as a special internal system, like we
already do for disclosure-closed.

* Source/WTF/wtf/unicode/CharacterNames.h:
* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::counterForSystemDisclosureClosed):
(WebCore::CSSCounterStyle::counterForSystemDisclosureOpen):
(WebCore::CSSCounterStyle::initialRepresentation const):
(WebCore::CSSCounterStyle::fallbackText):
(WebCore::CSSCounterStyle::text):
(WebCore::CSSCounterStyle::isInRange const):
* Source/WebCore/css/CSSCounterStyle.h:
(WebCore::CSSCounterStyle::text):
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
(WebCore::CSSCounterStyleDescriptors::areSymbolsValidForSystem):
(WebCore::CSSCounterStyleDescriptors::systemCSSText const):
* Source/WebCore/css/CSSCounterStyleDescriptors.h:
* Source/WebCore/css/CSSCounterStyleRule.cpp:
(WebCore::toCounterStyleSystemEnum):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/counterStyles.css:
(@counter-style disclosure-open):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeCounterStyleSystem):
* Source/WebCore/platform/text/WritingMode.h:
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::originalText const):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/280433@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications