[webkit-changes] [WebKit/WebKit] 0f6661: unexpected sound playback after page became visible

Commit Queue noreply at github.com
Thu Jun 27 12:12:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f6661c534e394364197fde5279bc5b2cb6df29e
      https://github.com/WebKit/WebKit/commit/0f6661c534e394364197fde5279bc5b2cb6df29e
  Author: Marat Isaev <m.isaev at corp.vk.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKit/playable-audio.html
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm

  Log Message:
  -----------
  unexpected sound playback after page became visible
https://bugs.webkit.org/show_bug.cgi?id=274056
<rdar://problem/128358265>

Reviewed by Eric Carlson.

do not resume playback if audible mediaelement is ended

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mayResumePlayback):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/playable-audio.html: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible.mm: Added.
(TEST(WebKit, NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm:

Canonical link: https://commits.webkit.org/280423@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list