[webkit-changes] [WebKit/WebKit] b35a3a: Forward notifications from the UI process to the W...

Per Arne Vollan noreply at github.com
Thu Jun 27 11:29:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b35a3a5d21193edf78d8c645f02045f8d3af039a
      https://github.com/WebKit/WebKit/commit/b35a3a5d21193edf78d8c645f02045f8d3af039a
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  -----------
  Forward notifications from the UI process to the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=275874
rdar://129602281

Reviewed by Sihui Liu and Ben Nham.

When a notification is being observed in the WebContent process, an OS fault is generated, unless this
notification has been added to an allow list in the entitlements. The purpose of this telemetry is to
detect which notifications we need to forward from the UI process. This patch adds a set of notifications
that has generated faults to the allow list. The notifications are also added to the list of forwarded
notifications, and to the sandbox so that they can be reposted in the WebContent process.

It is important to remove these OS faults by adding the notifications to these allow lists, since they
can be costly in terms of CPU usage.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/280421@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list