[webkit-changes] [WebKit/WebKit] c54171: MediaPlayerPrivateRemote should derive privately f...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c54171089372d22c1838e8ce92e1ec9dc638d3d6
      https://github.com/WebKit/WebKit/commit/c54171089372d22c1838e8ce92e1ec9dc638d3d6
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
    M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
    M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
    M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h
    M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm

  Log Message:
  -----------
  MediaPlayerPrivateRemote should derive privately from IPC::MessageReceiver
rdar://130574962
https://bugs.webkit.org/show_bug.cgi?id=275896

Reviewed by Eric Carlson.

This clarifies which base class weak pointer to take for MediaPlayerPrivateRemote.

* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::performTaskAtTime):
(WebKit::MediaPlayerPrivateRemote::requestHostingContextID):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::deleteRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::findRemotePlayerId):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnectionDidClose):
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h:
* Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
(-[WKVideoLayerRemote mediaPlayerPrivateRemote]):
(-[WKVideoLayerRemote resizePreservingGravity]):
(-[WKVideoLayerRemote layoutSublayers]):
(-[WKVideoLayerRemote resolveBounds]):

Canonical link: https://commits.webkit.org/280415@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications