[webkit-changes] [WebKit/WebKit] f4043d: [tvOS] Hide custom fullscreen controls when a vide...

aestes noreply at github.com
Wed Jun 26 09:51:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4043d01a8ce50588522034ce58ab83fbdb0d5cd
      https://github.com/WebKit/WebKit/commit/f4043d01a8ce50588522034ce58ab83fbdb0d5cd
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  -----------
  [tvOS] Hide custom fullscreen controls when a video element is in element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=275887
rdar://130560759

Reviewed by Aditya Keerthi and Eric Carlson.

Replaced PLATFORM(VISION) checks with ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN) to enable the ability to
hide custom fullscreen controls when a video element is in element fullscreen on tvOS.

* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController initWithWebView:]):
(-[WKFullScreenViewController videoControlsManagerDidChange]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):

Canonical link: https://commits.webkit.org/280379@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list