[webkit-changes] [WebKit/WebKit] 2b4f5e: [WGSL] Struct offset can overflow

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b4f5ef73598b70e32abd9def228f9d9f25462aa
      https://github.com/WebKit/WebKit/commit/2b4f5ef73598b70e32abd9def228f9d9f25462aa
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/tests/valid/struct.wgsl

  Log Message:
  -----------
  [WGSL] Struct offset can overflow
https://bugs.webkit.org/show_bug.cgi?id=275850
rdar://130092379

Reviewed by Mike Wyrzykowski.

We fixed a similar issue with the struct size overflowing in 279809 at main, but I missed
that the same could happen to the offset. The issue was that all the operations were
already using Checked types, except rounding up the offset to the required alignment,
which is where the overflow happened.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/tests/valid/struct.wgsl:

Canonical link: https://commits.webkit.org/280370@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications