[webkit-changes] [WebKit/WebKit] 6d2e5c: [GStreamer] Sample handling cleanups in text sink

Philippe Normand noreply at github.com
Wed Jun 26 04:24:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d2e5c0bc67adf9568e51f3aa10e515e88ad09ac
      https://github.com/WebKit/WebKit/commit/6d2e5c0bc67adf9568e51f3aa10e515e88ad09ac
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Sample handling cleanups in text sink
https://bugs.webkit.org/show_bug.cgi?id=275733

Reviewed by Xabier Rodriguez-Calvar.

Use GRefPtr and String instead of raw pointers when passing samples from the text sink to the
player.

* Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleTextSample):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkHandleSample):
(): Deleted.

Canonical link: https://commits.webkit.org/280367@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list