[webkit-changes] [WebKit/WebKit] 94d70d: Replace webrtc LogMessage::SetLogOutput with LibWe...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94d70d33e766baa6e8a4e25b5ff0c8f98382fd93
      https://github.com/WebKit/WebKit/commit/94d70d33e766baa6e8a4e25b5ff0c8f98382fd93
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-06-23 (Sun, 23 Jun 2024)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
    M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
    M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h
    M Source/WebCore/Modules/mediastream/RTCController.cpp
    M Source/WebCore/Modules/mediastream/RTCController.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.h
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp

  Log Message:
  -----------
  Replace webrtc LogMessage::SetLogOutput with LibWebRTCLogSink
rdar://130199443
https://bugs.webkit.org/show_bug.cgi?id=275681

Reviewed by Eric Carlson.

We remove from libwebrtc the WebKit specific logging mechanism.
Instead we use an existing mechanism via LibWebRTCLogSink.

We update LibWebRTCLogSink to send logs without hopping to main thread to keep the
same performance as the previous mechanism.
This removes the need for LibWebRTCLogSink to be a CanMakeWeakPtr.

We update RTCController to be RefCounted so that we can protect a RTCController from a WeakPtr.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h:
* Source/WebCore/Modules/mediastream/RTCController.cpp:
(WebCore::toWebRTCLogLevel):
(WebCore::RTCController::startGatheringLogs):
* Source/WebCore/Modules/mediastream/RTCController.h:
(WebCore::RTCController::create):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::disableICECandidateFiltering):
(WebCore::Page::enableICECandidateFiltering):
(WebCore::Page::didChangeMainDocument):
* Source/WebCore/page/Page.h:
(WebCore::Page::rtcController):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.cpp:
(WebCore::LibWebRTCLogSink::~LibWebRTCLogSink):
(WebCore::LibWebRTCLogSink::logMessage):
(WebCore::LibWebRTCLogSink::start):
(WebCore::LibWebRTCLogSink::stop):
(WebCore::toWebRTCLogLevel): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.h:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::getRTCLogSink):
(WebCore::LibWebRTCProvider::setRTCLogging):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::doReleaseLogging): Deleted.

Canonical link: https://commits.webkit.org/280288@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications