[webkit-changes] [WebKit/WebKit] 619f0e: REGRESSION(277275 at main) Excel login window is comp...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 619f0ebf6a1f107b8b9888fbd8b1b3d48dba0c33
      https://github.com/WebKit/WebKit/commit/619f0ebf6a1f107b8b9888fbd8b1b3d48dba0c33
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-06-22 (Sat, 22 Jun 2024)

  Changed paths:
    A LayoutTests/fast/table/table-with-out-of-flow-content-only-expected.html
    A LayoutTests/fast/table/table-with-out-of-flow-content-only.html
    M LayoutTests/platform/ios/css2.1/20110323/margin-applies-to-015-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/negative-right-pos-expected.txt
    M LayoutTests/platform/ios/fast/table/012-expected.txt
    M LayoutTests/platform/ios/fast/table/empty-cells-expected.txt
    M LayoutTests/platform/ios/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt
    M LayoutTests/platform/ios/tables/mozilla_expected_failures/other/empty_cells-expected.txt
    M LayoutTests/platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/negative-right-pos-expected.txt
    M LayoutTests/platform/mac/fast/table/012-expected.txt
    M LayoutTests/platform/mac/fast/table/empty-cells-expected.txt
    M LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt
    M LayoutTests/platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt
    M Source/WebCore/rendering/AutoTableLayout.cpp

  Log Message:
  -----------
  REGRESSION(277275 at main) Excel login window is compressed
https://bugs.webkit.org/show_bug.cgi?id=275766
<rdar://127376777>

Reviewed by Antti Koivisto.

Let's distribute the available space across columns when none of them has content (all cells are empty).
(This is a long-standing bug. 277275 at main just exposed it by not forcing AutoTableLayout::recalcColumn call -which incorrectly sets emptyCellsOnly to false for the subsequent AutoTableLayout::layout call).

* LayoutTests/fast/table/table-with-out-of-flow-content-only-expected.html: Added.
* LayoutTests/fast/table/table-with-out-of-flow-content-only.html: Added.
* Source/WebCore/rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):

(expected result changes -> all progressions)

Canonical link: https://commits.webkit.org/280277@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications