[webkit-changes] [WebKit/WebKit] bddd44: Calling browser.storage.set with undefined as a ma...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bddd449fd933358928d691b8b72f6b1f19da8571
      https://github.com/WebKit/WebKit/commit/bddd449fd933358928d691b8b72f6b1f19da8571
  Author: Kiara Rose <kiara_rose at apple.com>
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm

  Log Message:
  -----------
  Calling browser.storage.set with undefined as a map value throws an exception
https://bugs.webkit.org/show_bug.cgi?id=275746
rdar://130282050

Reviewed by Timothy Hatcher and Brian Weinstein.

We shouldn't throw an exception if undefined is passed as a value for {storageArea}.set().
This matches what we do currently in Safari.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm:
(WebKit::WebExtensionAPIStorageArea::set):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIStorage, Set)):

Canonical link: https://commits.webkit.org/280265@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications