[webkit-changes] [WebKit/WebKit] ddce44: Baseline at span is shifted inside the <strong> tag

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ddce4481ff7cd2208b413ce362232d01c304d6bf
      https://github.com/WebKit/WebKit/commit/ddce4481ff7cd2208b413ce362232d01c304d6bf
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
    A LayoutTests/fast/text/incorrect-baseline-with-nested-inline-box-expected.html
    A LayoutTests/fast/text/incorrect-baseline-with-nested-inline-box.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp

  Log Message:
  -----------
  Baseline at span is shifted inside the <strong> tag
https://bugs.webkit.org/show_bug.cgi?id=275699
<rdar://problem/130217599>

Reviewed by Antti Koivisto.

Simplified aligner is not meant to handle nested inline box cases (or any nesting for that matter).

* LayoutTests/fast/text/incorrect-baseline-with-nested-inline-box-expected.html: Added.
* LayoutTests/fast/text/incorrect-baseline-with-nested-inline-box.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):

Canonical link: https://commits.webkit.org/280255@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications