[webkit-changes] [WebKit/WebKit] d8035e: [Cocoa] CRASH in HTMLMediaElement::loadResource()

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8035e9cf316ae2ac0458fa0563e4f8354cd99ff
      https://github.com/WebKit/WebKit/commit/d8035e9cf316ae2ac0458fa0563e4f8354cd99ff
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  [Cocoa] CRASH in HTMLMediaElement::loadResource()
https://bugs.webkit.org/show_bug.cgi?id=275718
rdar://129570289

Reviewed by Eric Carlson.

>From crashlogs, loadResource() is being called when m_player is null. This should not be possible,
as the only site that clears m_player is clearMediaPlayer(), which cancels the task which calls
loadResource().

Null-check m_player, but leave an ASSERT_NOT_REACHED() in its place, to hopefully catch this state
in debug builds and layout tests.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):

Canonical link: https://commits.webkit.org/280251@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications