[webkit-changes] [WebKit/WebKit] e15967: shadowsIgnoreTransforms should negate the vertical...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e159672b31de0bf6435bd68411a33eb58d84b170
      https://github.com/WebKit/WebKit/commit/e159672b31de0bf6435bd68411a33eb58d84b170
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-06-19 (Wed, 19 Jun 2024)

  Changed paths:
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
    M Source/WebCore/platform/graphics/GraphicsContext.cpp
    M Source/WebCore/platform/graphics/GraphicsContext.h
    M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
    M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  -----------
  shadowsIgnoreTransforms should negate the vertical shadowOffset on Cocoa ports only
https://bugs.webkit.org/show_bug.cgi?id=275168
rdar://129291752

Reviewed by Kimmo Kinnunen.

For Cocoa ports negate the vertical shadowOffset if shadowsIgnoreTransforms() is
true. Remove the code from GraphicsContextCairo and GraphicsContextSkia which was
double negating the vertical shadowOffset.

* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::applyShadow):
Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformShadowOffset const):
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextCairo::didUpdateState):
* Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::FontCascade::drawGlyphs):
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::createDropShadowFilterIfNeeded const):

Canonical link: https://commits.webkit.org/280175@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications