[webkit-changes] [WebKit/WebKit] fc158b: REGRESSION(274853 at main): [GLib][MSE] Excessive CPU...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc158b61f4bedc9bc1a7dd01689a64c225c813d2
      https://github.com/WebKit/WebKit/commit/fc158b61f4bedc9bc1a7dd01689a64c225c813d2
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-06-19 (Wed, 19 Jun 2024)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  -----------
  REGRESSION(274853 at main): [GLib][MSE] Excessive CPU usage from cached web process after closing ksdk.com page, failure to display web content after reopening page, part 2
https://bugs.webkit.org/show_bug.cgi?id=274802

Reviewed by Xabier Rodriguez-Calvar.

The excessive CPU usage was due to mediaPlayerReadyStateChanged() recursing on itself forever after
being triggered due to the MediaSource closing procedure. In the WPE/GTK ports at least, the
isSuspended() condition is always true in this situation. The proposed workaround is to attempt a
fixed amount of recursions.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/280171@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications