[webkit-changes] [WebKit/WebKit] a07047: [view-transitions] Fix context menu and hit testin...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a07047cc7bce61b5aae4f2bfca6868d8d1a37b86
      https://github.com/WebKit/WebKit/commit/a07047cc7bce61b5aae4f2bfca6868d8d1a37b86
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-pseudo-element-element-from-point-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-pseudo-element-element-from-point.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point.html
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
    M Source/WebCore/rendering/RenderViewTransitionCapture.h

  Log Message:
  -----------
  [view-transitions] Fix context menu and hit testing when view transition is running
https://bugs.webkit.org/show_bug.cgi?id=275556
rdar://129976270

Reviewed by Matt Woodrow.

The context menu was broken because hit-testing was returning no element.

View transition pseudo-elements should hit-test to their originating element (document element).

Elements that are captured in a view transition should be ignored from hit testing.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-pseudo-element-element-from-point-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-pseudo-element-element-from-point.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point.html:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest const):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::nodeForHitTest const):
* Source/WebCore/rendering/RenderViewTransitionCapture.h:

Canonical link: https://commits.webkit.org/280154@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications