[webkit-changes] [WebKit/WebKit] 85caa2: Web Inspector: remove unnecessary uses of open fie...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85caa2d31dc1dbec7186471bd2442b73be14d380
      https://github.com/WebKit/WebKit/commit/85caa2d31dc1dbec7186471bd2442b73be14d380
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp
    M Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp
    M Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py
    M Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py
    M Source/JavaScriptCore/inspector/scripts/codegen/generator.py
    M Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/domain-debuggableTypes.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetTypes.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/should-strip-comments.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/type-with-open-parameters.json-result
    M Source/JavaScriptCore/inspector/scripts/tests/expected/version.json-result
    M Source/WebCore/inspector/InspectorStyleSheet.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp
    M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp

  Log Message:
  -----------
  Web Inspector: remove unnecessary uses of open fields in protocol
https://bugs.webkit.org/show_bug.cgi?id=275551

Reviewed by Timothy Hatcher.

Most of the uses of `Domain::Type::propertyKey` are unnecessary since `String` is super efficient with `ASCIILiteral`.

* Source/JavaScriptCore/inspector/scripts/codegen/generator.py:
* Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
(CppProtocolTypesHeaderGenerator._generate_class_for_object_declaration): Deleted.
* Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:
(CppProtocolTypesImplementationGenerator.generate_output):
(CppProtocolTypesImplementationGenerator._generate_assertion_for_object_declaration):
(CppProtocolTypesImplementationGenerator._generate_open_field_names): Deleted.

* Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::parseBreakpointOptions):
(Inspector::parseLocation):
* Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties const):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::gridOverlayConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::flexOverlayConfigFromInspectorObject):
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::findStorageArea):
* Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::Inspector::idbKeyFromInspectorObject):
(WebCore::Inspector::idbKeyRangeFromKeyRange):
* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::didReceiveResponse):
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::parseCookieObject):
* Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteRecordEntry):
(WebCore::InspectorTimelineAgent::appendRecord):

* Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetTypes.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/should-strip-comments.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/type-with-open-parameters.json-result:
* Source/JavaScriptCore/inspector/scripts/tests/expected/version.json-result:

Canonical link: https://commits.webkit.org/280146@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications