[webkit-changes] [WebKit/WebKit] 28e8c9: Reduce code duplication in SiteIsolation.mm

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28e8c9518098caa802fabc81fda8ef46eb1f42a2
      https://github.com/WebKit/WebKit/commit/28e8c9518098caa802fabc81fda8ef46eb1f42a2
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  -----------
  Reduce code duplication in SiteIsolation.mm
https://bugs.webkit.org/show_bug.cgi?id=275576
rdar://130018166

Reviewed by Alex Christensen.

Site isolation API tests do certain things often, like evaluate JavaScript in an iframe or get the node
for the main frame or its first child frame. We should have helper functions instead of duplicating the
code in tests.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, PreferencesUpdatesToAllProcesses)):
(TestWebKitAPI::TEST(SiteIsolation, ParentOpener)):
(TestWebKitAPI::TEST(SiteIsolation, CloseAfterWindowOpen)):
(TestWebKitAPI::TEST(SiteIsolation, PostMessageWithMessagePorts)):
(TestWebKitAPI::TEST(SiteIsolation, PostMessageWithNotAllowedTargetOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, PostMessageToIFrameWithOpaqueOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, QueryFramesStateAfterNavigating)):
(TestWebKitAPI::TEST(SiteIsolation, NavigatingCrossOriginIframeToSameOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, ParentNavigatingCrossOriginIframeToSameOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, IframeNavigatesSelfWithoutChangingOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, IframeWithConfirm)):
(TestWebKitAPI::TEST(SiteIsolation, IframeWithPrompt)):
(TestWebKitAPI::TEST(SiteIsolation, ChildNavigatingToNewDomain)):
(TestWebKitAPI::TEST(SiteIsolation, ChildNavigatingToMainFrameDomain)):
(TestWebKitAPI::TEST(SiteIsolation, ChildNavigatingToSameDomain)):
(TestWebKitAPI::TEST(SiteIsolation, ChildNavigatingToDomainLoadedOnADifferentPage)):
(TestWebKitAPI::TEST(SiteIsolation, MainFrameWithTwoIFramesInTheSameProcess)):
(TestWebKitAPI::TEST(SiteIsolation, ChildBeingNavigatedToMainFrameDomainByParent)):
(TestWebKitAPI::TEST(SiteIsolation, ChildBeingNavigatedToSameDomainByParent)):
(TestWebKitAPI::TEST(SiteIsolation, CrossOriginOpenerPolicy)):
(TestWebKitAPI::TEST(SiteIsolation, PropagateMouseEventsToSubframe)):
(TestWebKitAPI::TEST(SiteIsolation, RunOpenPanel)):
(TestWebKitAPI::TEST(SiteIsolation, PasteGIF)):
(TestWebKitAPI::TEST(SiteIsolation, OpenerProcessSharing)):
(TestWebKitAPI::TEST(SiteIsolation, SetFocusedFrame)):
(TestWebKitAPI::TEST(SiteIsolation, EvaluateJavaScriptInFrame)):
(TestWebKitAPI::TEST(SiteIsolation, MainFrameURLAfterFragmentNavigation)):
(TestWebKitAPI::TEST(SiteIsolation, FocusOpenedWindow)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringInFrame)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringInNestedFrame)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelection)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionWithEmptyFrames)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionNoWrap)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionBackwards)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionSameOriginFrames)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionNestedFrames)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionMultipleMatchesInMainFrame)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionMultipleMatchesInChildFrame)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringSelectionSameOriginFrameBeforeWrap)):
(TestWebKitAPI::TEST(SiteIsolation, FindStringMatchCount)):
(TestWebKitAPI::TEST(SiteIsolation, CustomUserAgent)):
(TestWebKitAPI::TEST(SiteIsolation, ApplicationNameForUserAgent)):
(TestWebKitAPI::TEST(SiteIsolation, WebsitePoliciesCustomUserAgent)):
(TestWebKitAPI::TEST(SiteIsolation, WebsitePoliciesCustomNavigatorPlatform)):
(TestWebKitAPI::TEST(SiteIsolation, ProvisionalLoadFailureOnCrossSiteRedirect)):
(TestWebKitAPI::TEST(SiteIsolation, SynchronouslyExecuteEditCommandSelectAll)):
(TestWebKitAPI::TEST(SiteIsolation, SelectAll)):
(TestWebKitAPI::TEST(SiteIsolation, TopContentInsetAfterCrossSiteNavigation)):
(TestWebKitAPI::TEST(SiteIsolation, CanGoBackAfterLoadingAndNavigatingFrame)):
(TestWebKitAPI::TEST(SiteIsolation, CanGoBackAfterNavigatingFrameCrossOrigin)):
(TestWebKitAPI::TEST(SiteIsolation, NavigateIframeSameOriginBackForward)):
(TestWebKitAPI::TEST(SiteIsolation, NavigateIframeCrossOriginBackForward)):
(TestWebKitAPI::TEST(SiteIsolation, NavigateNestedIframeSameOriginBackForward)):
(TestWebKitAPI::TEST(SiteIsolation, AdvancedPrivacyProtectionsHideScreenMetricsFromBindings)):
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView mainFrame]):
(-[TestWKWebView firstChildFrame]):
(-[TestWKWebView evaluateJavaScript:inFrame:completionHandler:]):
(-[TestWKWebView findStringAndWait:withConfiguration:]):

Canonical link: https://commits.webkit.org/280137@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications