[webkit-changes] [WebKit/WebKit] e999bc: CTS api, validation, encoding, cmds, render, * test is ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e999bcebefdcbbfd16744dc545413c2cacc31ed3
      https://github.com/WebKit/WebKit/commit/e999bcebefdcbbfd16744dc545413c2cacc31ed3
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-18 (Tue, 18 Jun 2024)

  Changed paths:
    M LayoutTests/fast/webgpu/regression/repro_275024-expected.txt
    M LayoutTests/fast/webgpu/regression/repro_275024b-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/draw-expected.txt
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  CTS api,validation,encoding,cmds,render,* test is failing
https://bugs.webkit.org/show_bug.cgi?id=275513
<radar://129874785>

Reviewed by Tadeu Zagallo.

279708 at main introduced incorrect validation for invalid draw calls,
instead of reverting it which would reintroduce the buffer overflow,
correct the logic so invalid draws produce the expected validation error.

Also enable the impacted test to avoid regressing the CTS test moving
forwards.

* LayoutTests/fast/webgpu/regression/repro_275024-expected.txt:
* LayoutTests/fast/webgpu/regression/repro_275024b-expected.txt:
Update expectations, this case should not be a validation error per
the specification.

* LayoutTests/platform/mac-wk2/TestExpectations:
Add test to passing list.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
(WebGPU::RenderBundleEncoder::computeMininumVertexInstanceCount const):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount const):
Correct logic.

Canonical link: https://commits.webkit.org/280129@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications