[webkit-changes] [WebKit/WebKit] 3fecce: [results.webkit.org] ⌘F should not override system...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fecce8a9b38374458fabf95582d6be8074fe357
      https://github.com/WebKit/WebKit/commit/3fecce8a9b38374458fabf95582d6be8074fe357
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js

  Log Message:
  -----------
  [results.webkit.org] ⌘F should not override system find-in-page if the search panel is collapsed
https://bugs.webkit.org/show_bug.cgi?id=275531

Reviewed by BJ Burg.

Avoid preventing default and attempting to focus the search field when the user presses ⌘F, if the
search field is disabled (and therefore cannot be edited in the first place). The existing logic
makes it difficult to invoke the browser's built-in find-in-page functionality at all in
results.webkit.org, which can be useful in some cases (e.g. when searching for specific trains, OS
build versions, etc.).

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:

Also drive-by-fix a typo in a nearby local variable.

Canonical link: https://commits.webkit.org/280092@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications