[webkit-changes] [WebKit/WebKit] 199e7c: [WebGPU] Invalid bounds check in RenderPassEncoder

mwyrzykowski noreply at github.com
Mon Jun 17 12:02:31 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 199e7c1a1ed85d1cf065143ed7c516518ccb7d27
      https://github.com/WebKit/WebKit/commit/199e7c1a1ed85d1cf065143ed7c516518ccb7d27
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Invalid bounds check in RenderPassEncoder
https://bugs.webkit.org/show_bug.cgi?id=275490
<radar://129843768>

Reviewed by Tadeu Zagallo.

The bounds check was incorrect, though I don't think in practice it
was possible to trigger it even through IPC.

Replace the RELEASE_ASSERT + memcpy with memcpySpan to ensure the
memcpy is safe.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):

Canonical link: https://commits.webkit.org/280082@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list